-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bundle: updates for 0.12.0 #488
bundle: updates for 0.12.0 #488
Conversation
Update the operatorhub bundle for the 0.12.0 release Signed-off-by: stevenhorsman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@@ -13,4 +13,4 @@ kind: Kustomization | |||
images: | |||
- name: controller | |||
newName: quay.io/confidential-containers/operator | |||
newTag: v0.10.0 | |||
newTag: v0.12.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be also latest
so that the kustomization in main HEAD always matches the latest image but make bundle
seems to force a VERSION
tag...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it looks like in the past I updated this back to latest post-release (81a89f9), so we could add this to our post release tasks? Or alternatively update config/default/kustomization.yaml
to have
images:
- name: quay.io/confidential-containers/operator
newTag: latest
as I mentioned on slack, which I think should have the same effect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or alternatively update
config/default/kustomization.yaml
to have
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating config/default/kustomization.yaml to use latest image is the best option IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool - we can do that once the release is all tied up I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a quick look and it seems the overall flow needs rework: make bundle
sets the image tag but it has no effect since config/manifest
actually uses config/release
as the target that sets an image tag that is decoupled from VERSION
used by make bundle
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix @stevenhorsman !
We do not need a new tag for this release, right? Can we make sure to add this to the release checklist? I guess it is part of step 8 but we should maybe clarify that. |
No, I've got a workaround on the CAA side and I think this should resolve the issue anyway
Sorry, I'm not sure what you mean by this? |
Is there something we have forgotten to do in previous releases? If so we should add it to the release template section. I missed most of the discussion on this one due to being asleep. |
So in the last release the operatorhub bundle wasn't done, but that wouldn't have helped the problem we hit. There has been some discussion over whether we want to roll back the
as I think we encourage users to use the release config and default is just for dev, so that can stay as latest? |
Ok, got it. I think I am caught up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I submitted the k8s-operatorhub/community-operators#5611 to publish 0.10.2 bundle in operator hub and these are the changes on our side for the publish.